Adds unit to metrics before calling CollectMetrics #1533

jcooklin · 2017-02-23T00:40:15Z

Adds 'unit' to metrics before calling collect

Summary of changes:

Adds unit to metrics before calling CollectMetrics

Testing done:

Manual
Existing unit

Given plugins:

▶ snaptel plugin list
NAME 			 VERSION 	 TYPE 		 SIGNED 	 STATUS 	 LOADED TIME
mock-grpc 		 1 		 collector 	 false 		 loaded 	 Wed, 22 Feb 2017 16:30:21 PST
test-file-publisher 	 1 		 publisher 	 false 		 loaded 	 Wed, 22 Feb 2017 16:30:22 PST

Task:

---
  version: 1
  schedule:
    type: "simple"
    interval: "1s"
  workflow:
    collect:
      metrics:
        ?intel?mock?/bar⽔: {}
      config:
        /random:
          return_error: false
      publish:
        -
          plugin_name: test-file-publisher
          config:
            file: /tmp/rand-file.out

Before

After

@intelsdi-x/snap-maintainers

- Adds 'unit' to metrics before calling collect

IzabellaRaulin

LGTM

Fixes intelsdi-x#1532

8eb0d7c

- Adds 'unit' to metrics before calling collect

jcooklin mentioned this pull request Feb 23, 2017

Empty Unit field on CollectMetrics function intelsdi-x/snap-plugin-lib-go#61

Closed

IRCody approved these changes Feb 23, 2017

View reviewed changes

IzabellaRaulin approved these changes Feb 23, 2017

View reviewed changes

IzabellaRaulin merged commit 92062aa into intelsdi-x:master Feb 23, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds unit to metrics before calling CollectMetrics #1533

Adds unit to metrics before calling CollectMetrics #1533

jcooklin commented Feb 23, 2017

IzabellaRaulin left a comment

Adds unit to metrics before calling CollectMetrics #1533

Adds unit to metrics before calling CollectMetrics #1533

Conversation

jcooklin commented Feb 23, 2017

Before

After

IzabellaRaulin left a comment

Choose a reason for hiding this comment